The GitHub Actions job "Required Checks" on texera.git/xinyuan-loop-feb has failed. Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run: 7fd110a83336200ba93206cf3dac0a9da86f6b2e / Xinyuan Lin <[email protected]> refactor+test(loop): gate MATERIALIZED check on an operator flag, not a class Addresses PR #4206 review feedback (https://github.com/apache/texera/pull/4206#discussion_r3400851505): the execution-mode check used isInstanceOf[LoopStartOpDesc], which (1) tied a generic service to one operator class, (2) only matched LoopStart -- a plan with a LoopEnd but no LoopStart would skip the check -- and (3) had no test. (This was done earlier but lost when the branch was rebased.) * Add LogicalOp.requiresMaterializedExecution (default false); LoopStart and LoopEnd both override it to true. * Extract WorkflowExecutionService.validateExecutionMode(operators, settings) -- a pure, testable method that throws an IllegalArgumentException with an actionable message when the plan needs MATERIALIZED but the request asked for something else. Keyed off the flag, so the service no longer imports or matches LoopStartOpDesc, and Loop Start OR Loop End on its own triggers it. * The constructor delegates to it (still fail-loud, per the earlier decision). * New WorkflowExecutionServiceSpec: the flag is set on both loop ops and unset on a non-loop op (SleepOpDesc); validateExecutionMode rejects a loop+PIPELINED plan (incl. a LoopEnd-only plan), and accepts loop+MATERIALIZED, non-loop+PIPELINED, and an empty plan. Verified locally: 6 new tests pass, 29 LoopStart/LoopEnd op-desc specs pass, amber compiles. Report URL: https://github.com/apache/texera/actions/runs/27451582171 With regards, GitHub Actions via GitBox
