The GitHub Actions job "Required Checks" on texera.git/xinyuan-loop-feb has 
failed.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
3f11520450f40b58ad956a0765957fe1b11fa620 / Xinyuan Lin <[email protected]>
docs(loop): document reset_output_storage firing condition at the call site

Addresses PR #4206 review feedback
(https://github.com/apache/texera/pull/4206#discussion_r3400851498): the
reviewer read the reset_output_storage() call in process_input_state
against the (stale) PR description and was unsure when it fires.

The code is correct -- reset fires once per iteration for every LoopEnd
on its matching-loop consume (loop_counter == 0); the nested pass-through
(loop_counter > 0) is forwarded and returned in _process_state_frame
before reaching this call, so it never resets. Add a comment at the call
site stating this, matching the reset_output_storage docstring. No
behavior change. (The PR description, which had the wrong claim, is
corrected separately.)

Report URL: https://github.com/apache/texera/actions/runs/27452601753

With regards,
GitHub Actions via GitBox

Reply via email to