Cole-Greer commented on code in PR #3118:
URL: https://github.com/apache/tinkerpop/pull/3118#discussion_r2087289020
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/FormatStep.java:
##########
@@ -168,6 +169,19 @@ public Set<String> getScopeKeys() {
return variables;
}
+ @Override
+ public Set<ScopingInfo> getScopingInfo() {
Review Comment:
As each step contains a Set of labels, but only one Pop, would it be easier
for ScopingInfo to be defined as
```
public static class ScopingInfo {
public Set<String> labels;
public Pop pop;
```
and for this method to return `ScopingInfo` instead of `Set<ScopingInfo>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
