spmallette commented on code in PR #3118:
URL: https://github.com/apache/tinkerpop/pull/3118#discussion_r2087349586
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/Scoping.java:
##########
@@ -166,6 +167,13 @@ public default <S> S getNullableScopeValue(final Pop pop,
final String key, fina
*/
public Set<String> getScopeKeys();
+ /**
+ * Used to get ScopingInfo of a Step that implements Scoping. Scoping info
includes the labels it needs, and the pop type for each label.
+ *
+ * @return A Set of {@link ScopingInfo} values which contain the label and
Pop value
+ */
+ public default Set<ScopingInfo> getScopingInfo() {return null; }
Review Comment:
Should there be a default implementation here? If something implements
`Scoping` shouldn't it have a proper implementation? or are there cases where
you would return `getScopeKeys` but not `getScopingInfo`? and if so, would
`return null` be the right default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
