spmallette commented on code in PR #3118:
URL: https://github.com/apache/tinkerpop/pull/3118#discussion_r2087347460
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/Scoping.java:
##########
@@ -185,4 +193,39 @@ public Scoping getStep() {
return step;
}
}
+
+
+ /**
+ * A class for storing the Scoping information. It has two elements:
+ * - label: String
+ * - pop: Pop value
+ */
+ public static class ScopingInfo {
Review Comment:
Just a comment on naming - we have `getScopeKeys` so I feel like we should
leave the "ing" suffix for the interface and the non-active "Scope" for the
things the interface exposes. Perhaps we call this `ScopeInfo` or
`ScopeContext` (I prefer the latter i think because we don't use "Info"
anywhere in our code, but we do use "Context" in places) and have a
`Scoping.getScopeContext()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
