spmallette commented on code in PR #3157:
URL: https://github.com/apache/tinkerpop/pull/3157#discussion_r2251289887
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/P.java:
##########
@@ -269,4 +292,45 @@ public static P test(final PBiPredicate biPredicate, final
Object value) {
public static <V> P<V> not(final P<V> predicate) {
return predicate.negate();
}
+
+ public boolean isParameterized() {
+ if (gValue != null && gValue.isVariable()) {
+ return true;
+ }
+ if (gValues != null) {
+ for (final GValue<V> gValue : gValues) {
Review Comment:
I'm wary of loops in places where I know strategies will tread. Envisioning
a large `P.within(...)` creating a bottleneck. Does this have to be determined
dynamically? Could parameterization be determined once at construction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
