spmallette commented on code in PR #3157:
URL: https://github.com/apache/tinkerpop/pull/3157#discussion_r2251448443
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -3991,6 +4574,61 @@ public default <E2> GraphTraversal<S, E> option(final
Traversal<?, E2> traversal
return this;
}
+ /**
+ * This is a step modulator to a {@link TraversalOptionParent} like {@code
choose()} or {@code mergeV()} where the
+ * provided argument associated to the {@code token} is applied according
to the semantics of the step. Please see
+ * the documentation of such steps to understand the usage context.
+ *
+ * @param token the token that would trigger this option which may
be a {@link Pick}, {@link Merge},
+ * a {@link Traversal}, {@link Predicate}, or object
depending on the step being modulated.
+ * @param traversalOption the option as a traversal
+ * @return the traversal with the modulated step
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#choose-step"
target="_blank">Reference Documentation - Choose Step</a>
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#mergev-step"
target="_blank">Reference Documentation - MergeV Step</a>
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#mergee-step"
target="_blank">Reference Documentation - MergeE Step</a>
+ * @since 3.8.0
+ */
+ public default <M, E2> GraphTraversal<S, E> option(final GValue<M> token,
final Traversal<?, E2> traversalOption) {
Review Comment:
Do we need this overload? In what context is ` GValue<M> token` used? can
this be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]