spmallette commented on code in PR #3157:
URL: https://github.com/apache/tinkerpop/pull/3157#discussion_r2251400339
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -2852,6 +3410,9 @@ public default GraphTraversal<S, E> drop() {
* @since 3.7.1
*/
public default <S2> GraphTraversal<S, E> all(final P<S2> predicate) {
+ if (predicate != null && predicate.isParameterized()) {
+ throw new IllegalArgumentException("Parameterized predicates are
not supported by all()"); //TODO:: should this be supported?
Review Comment:
noticed a few TODOs with this question around use of `GValue` with `P` in
these cases and I'd say: no, shouldn't be supported right now. can always be
added later. i think you could remove the TODOs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
