zhiics commented on a change in pull request #4657: [CodeGen] Generate blob use
LLVM directly
URL: https://github.com/apache/incubator-tvm/pull/4657#discussion_r364363249
##########
File path: python/tvm/build_module.py
##########
@@ -632,6 +632,10 @@ def build(inputs,
if not target_host:
target_host = "llvm" if module.enabled("llvm") else "stackvm"
+ # set the target host based on llvm
Review comment:
do we really need to set target here? can we just pass
`target.create("llvm")` at line 145 of `module.py` when it is enabled? Then we
can remove a lot of code that are rarely/never used at any other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
