zhiics commented on a change in pull request #4657: [CodeGen] Generate blob use
LLVM directly
URL: https://github.com/apache/incubator-tvm/pull/4657#discussion_r364364907
##########
File path: src/codegen/build_module.cc
##########
@@ -882,6 +887,16 @@ TVM_REGISTER_GLOBAL("_GetCurrentTarget")
*ret = Target::Current(allow_not_defined);
});
+TVM_REGISTER_GLOBAL("_GetLLVMTargetHost")
+.set_body([](TVMArgs args, TVMRetValue* ret) {
+ *ret = Target::GetLLVMTargetHost();
+});
+
+TVM_REGISTER_GLOBAL("_SetLLVMTargetHost")
Review comment:
Yeah, I don't think this is necessary. I have some comments above, please
see if they make sense. We know exactly where we need LLVM target so we can
probably just directly use it, instead of using these wrappers which seem
unsafe to me as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
