zhiics commented on a change in pull request #4657: [CodeGen] Generate blob use LLVM directly URL: https://github.com/apache/incubator-tvm/pull/4657#discussion_r364361636
########## File path: include/tvm/codegen.h ########## @@ -59,6 +59,21 @@ runtime::Module Build(const Array<LoweredFunc>& funcs, * \return cstr The C string representation of the file. */ std::string PackImportsToC(const runtime::Module& m, bool system_lib); + +/*! + * \brief Pack imported device library to a LLVM module. + * Compile the LLVM module and link with the host library + * will allow the DSO loader to automatically discover and import + * the dependency from the shared library. + * + * \param m The host module with the imports. + * \param system_lib Whether expose as system library. + * \param target LLVM target + * \return runtime::Module The generated LLVM module. + */ +runtime::Module PackImportsToLLVM(const runtime::Module& m, + bool system_lib, + const std::string& target); Review comment: use `Target` here looks better than string ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
