tqchen commented on a change in pull request #4684: [Arith] add ShapeVar
representing non-neg valued variable in a tensor shape
URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365612051
##########
File path: src/arithmetic/bound_deducer.cc
##########
@@ -297,6 +331,18 @@ void BoundDeducer::Transform() {
void BoundDeducer::Deduce() {
Init();
if (!success_) return;
+
+ // Any variable appears in both expr and result,
Review comment:
I do not understand the following comment. Why would n/4 be simplified to 0?
if n>=0 the simplification rule does not stand, if n< 4, then it is a valid
simplification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
