tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365928309
########## File path: src/arithmetic/int_set.cc ########## @@ -529,6 +554,22 @@ class IntervalSetEvaluator : return Combine<T>(analyzer_, a, b); } + template<typename T> + inline IntervalSet VisitDivExpr_(const T* op) { + IntervalSet a = this->Eval(op->a); + IntervalSet b = this->Eval(op->b); + if ((MatchPoint(a, op->a) && (MatchPoint(b, op->b) || SelfBoundedVar(b, op->b))) + || (SelfBoundedVar(a, op->a) && SelfBoundedVar(b, op->b))) { + // e.g., Review comment: i think this can be fixed by having shape_var return single_pt ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services