yzhliu commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r366114637
########## File path: src/arithmetic/bound_deducer.cc ########## @@ -297,6 +331,18 @@ void BoundDeducer::Transform() { void BoundDeducer::Deduce() { Init(); if (!success_) return; + + // Any variable appears in both expr and result, Review comment: as it is also using `IntervalSetEvaluator`, this is also not required after having shape_var return single_pt ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services