masahi commented on a change in pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#discussion_r489063663



##########
File path: python/tvm/relay/frontend/pytorch.py
##########
@@ -1141,14 +1264,14 @@ def _impl(inputs, input_types):
             bias = inputs[0]
             return _op.nn.bias_add(dense_out, bias)
         else:
-            return dense_out
+            return dense_out + _expr.const(inputs[0])

Review comment:
       why this is needed? This is for use_bias == False case right?
   
   UPDATE: Oh probably we could have a better name than `use_bias`... I wonder 
why bias is the first argument.
   
   ```
   use_bias = isinstance(inputs[0], _expr.Expr)
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to