giuseros commented on a change in pull request #6714:
URL: https://github.com/apache/incubator-tvm/pull/6714#discussion_r514421590
##########
File path: python/tvm/topi/generic/conv2d.py
##########
@@ -51,7 +51,7 @@ def fallback_schedule_cpu_common_int8(cfg, wkl, int32_lanes,
num_int8_elements):
num_int8_elements,
)
- oc_bn = int32_lanes
+ oc_bn = int32_lanes if int32_lanes >= num_int8_elements else
num_int8_elements
Review comment:
Sorry if I don't understand this, but how the number of int32_lanes s
can change? Isn't it a function of the data-type and the vector size of the
machine?
##########
File path: python/tvm/topi/generic/conv2d.py
##########
@@ -180,7 +180,7 @@ def schedule_conv_NCHWc_cpu_common_int8(
ow_chunk, ow_block = s[CC].split(ow, factor=reg_n)
assert oc_bn % int32_lanes == 0
- assert ic_bn % 4 == 0 # 4 (u)int8 elements in (u)int32
+ assert ic_bn % int8_elems == 0 # (u)int8 elements in (u)int32
Review comment:
Are you sure that this comment is still valid? I think it might be
removed, but otherwise I would write: "input channels should be a multiple of
the numer of int8 elements we read"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
