cbalint13 commented on a change in pull request #6714:
URL: https://github.com/apache/incubator-tvm/pull/6714#discussion_r514608916
##########
File path: python/tvm/topi/generic/conv2d.py
##########
@@ -180,7 +180,7 @@ def schedule_conv_NCHWc_cpu_common_int8(
ow_chunk, ow_block = s[CC].split(ow, factor=reg_n)
assert oc_bn % int32_lanes == 0
- assert ic_bn % 4 == 0 # 4 (u)int8 elements in (u)int32
+ assert ic_bn % int8_elems == 0 # (u)int8 elements in (u)int32
Review comment:
@giuseros ,
* In short it mean: "int8 element, booth uint8(weight), uint8(data) products
are accumulated up into int32 lanes."
* Comment still valid,```ic_bn``` should be times of ```int8_elems``` (inner
loop cannot be tensorized otherwise).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
