masahi commented on a change in pull request #7074: URL: https://github.com/apache/tvm/pull/7074#discussion_r539769256
########## File path: src/relay/qnn/op/requantize.cc ########## @@ -263,6 +263,14 @@ bool RequantizeRel(const Array<Type>& types, int num_inputs, const Attrs& attrs, return false; } + if (types[0].as<IncompleteTypeNode>()) { Review comment: @mbrookhart I think this is not necessary, as this case is already covered by https://github.com/apache/tvm/blob/main/src/relay/qnn/op/requantize.cc#L260-L264 above ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org