jwfromm commented on a change in pull request #7074:
URL: https://github.com/apache/tvm/pull/7074#discussion_r539823312
##########
File path: src/relay/qnn/op/convolution.cc
##########
@@ -57,22 +59,27 @@ bool QnnConv2DRel(const Array<Type>& types, int num_inputs,
const Attrs& attrs,
ICHECK(param->out_dtype.bits() > 0) << "Output dtype bits should be greater
than 0.";
// Check the types of scale and zero points.
+ for (size_t i = 2; i < 5; ++i) {
Review comment:
Am I counting wrong or is this skipping `weight_scale`?
##########
File path: src/relay/qnn/op/requantize.cc
##########
@@ -256,13 +256,20 @@ Expr RequantizeQnnCanonicalize(const Attrs& attrs, const
Array<Expr>& new_args,
*/
bool RequantizeRel(const Array<Type>& types, int num_inputs, const Attrs&
attrs,
const TypeReporter& reporter) {
+ // Expected Types: data, input_scale, input_zero_point, output_scale,
output_zero_point, output
ICHECK_EQ(types.size(), 6);
const auto* data = types[0].as<TensorTypeNode>();
if (data == nullptr) {
return false;
}
+ // Check the scale and zero point types
+ for (size_t i = 3; i < 5; ++i) {
Review comment:
These values also dont seem to line up with expected types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
