mbrookhart commented on a change in pull request #7074:
URL: https://github.com/apache/tvm/pull/7074#discussion_r539814026
##########
File path: src/relay/qnn/op/op_common.h
##########
@@ -171,6 +171,11 @@ static inline bool QnnBroadcastRel(const Array<Type>&
types, int num_inputs, con
ICHECK_EQ(types.size(), kNumQnnBinaryOpArgTypes);
// Check the scale and zero point types
+ for (size_t i = 0; i < 8; ++i) {
Review comment:
Yes, it has tensor, scale, zero point for lhs, rhs, and output, added
more comments
##########
File path: src/relay/qnn/op/requantize.cc
##########
@@ -263,6 +263,14 @@ bool RequantizeRel(const Array<Type>& types, int
num_inputs, const Attrs& attrs,
return false;
}
+ if (types[0].as<IncompleteTypeNode>()) {
Review comment:
Good catch, thanks!
##########
File path: src/relay/qnn/op/requantize.cc
##########
@@ -263,6 +263,14 @@ bool RequantizeRel(const Array<Type>& types, int
num_inputs, const Attrs& attrs,
return false;
}
+ if (types[0].as<IncompleteTypeNode>()) {
+ return false;
+ }
+ for (size_t i = 3; i < 5; ++i) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
