zackcquic commented on pull request #8220: URL: https://github.com/apache/tvm/pull/8220#issuecomment-859652886
> Thanks for prompt feedbacks @zackcquic @tkonolige ! > > Here are some comments for Zack's questions: > > 1. What happens when exceptions occur in different instrument point. > Added in pass_infra.txt. But it is a little long. You might want to take a look again. > 2. Standard Instrument section: PassTimingInstrument, PrintBefore(TODO), PrintAfter(TODO), .. > I think it might be better to maintain these in the doc string of related Python class/function. > So I add example to instrument.py. It will be shown in Python API reference. > 3. Global PassContext and override_instrument examples > Done. Sorry for not aware of this approach. > 4. use_pass_infra.py's comments should be updated, sorry, I forgot to update it. > Done. > 5. conf.py should be updated. > Done. But actually it seems to automatically append un-listed tutorials to the end. > How do you think about the current order of tutorial? Thanks a lot for the hard work, its very helpful. For 2, I think it should be mentioned in this doc, like [https://tvm.apache.org/docs/dev/virtual_machine.html#optimizations] If maybe a little hard to find (eg grep the whole source without knowing the name). For 3, I think it needs a little section: Since passes can be used without explicit PassContext, so we introduced ``override...`` // ... more description For 5. I would like to group pass related together, it seems done in the latest fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
