chiwwang edited a comment on pull request #8220:
URL: https://github.com/apache/tvm/pull/8220#issuecomment-860725987
Ah! I saw what confused me. It's the level of "Pass Registration" section.
The current _pass_infra.rst_ section-hierachy is
**Pass Infrastructure** (Topest)
- The Design
**The design of backend and frontend are described here.**
* C++ Backend
- PassContext
- Pass Constructs
- Module-Level Passes
- Function-Level Passes
- Sequential Passes
* Pass Registration <-----This section has the same level with
Backend/Frontend.
* Python Frontend
- PassContext
- Pass Objects
Now I add Pass Instrument as:
**Pass Infrastructure** (Topest)
- The Design
**The design of backend and frontend are described here.**
* C++ Backend
- PassContext
- Pass Constructs
- Module-Level Passes
- Function-Level Passes
- Sequential Passes
- Pass Registration <----- May I fix this to have the same level
with other sub-sections in C++ backend?
- Pass Instruments <--- Added in this PR.
- Built-in Instrument <--- Added in this PR.
* Python Frontend
- PassContext
- Pass Objects
- Pass Instrument <--- Added in this PR.
- Override Instruments in Current PassContext <--- Added in this PR.
This might looks matching with descriptions in "The Design" section.
Or, could we isolate Pass Instrument, and have another topest section as
**Pass Infrastructure**?
May I know your thoughts @zackcquic @areusch ?
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
