vinx13 commented on a change in pull request #8366:
URL: https://github.com/apache/tvm/pull/8366#discussion_r667362619
##########
File path: src/te/operation/cross_thread_reduction.cc
##########
@@ -1,3 +1,4 @@
+
Review comment:
remove this line
##########
File path: src/te/operation/cross_thread_reduction.cc
##########
@@ -177,7 +178,8 @@ Stmt MakeCrossThreadReduction(const ComputeOpNode* self,
const Stage& stage,
std::vector<Var> res_handles(size);
for (size_t idx = 0; idx < size; ++idx) {
DataType dtype = reduces[idx]->dtype;
- res_handles[idx] = Var("reduce_temp" + std::to_string(idx),
PointerType(PrimType(dtype)));
+ res_handles[idx] =
Review comment:
shall we remove `storage_scope` attr here
https://github.com/apache/tvm/blob/f459dbfd3a09e5bcba25fd6838cf878efb961fa7/src/te/operation/cross_thread_reduction.cc#L229
https://github.com/apache/tvm/blob/f459dbfd3a09e5bcba25fd6838cf878efb961fa7/src/te/operation/cross_thread_reduction.cc#L234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
