vinx13 commented on a change in pull request #8366:
URL: https://github.com/apache/tvm/pull/8366#discussion_r667369887
##########
File path: src/tir/transforms/lower_thread_allreduce.cc
##########
@@ -33,10 +33,33 @@
#include "../../runtime/thread_storage_scope.h"
#include "ir_utils.h"
+#include "update_pointer_storage_scope.h"
namespace tvm {
namespace tir {
+class UpdatePointerStorageScopeAllReduce final : public
UpdatePointerStorageScope {
Review comment:
Can we merge this pass with `UpdatePointerStorageScope` by adding check
for `attr::volatile_scope` in `VisitStmt_(const AttrStmtNode*)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]