masahi commented on a change in pull request #8366:
URL: https://github.com/apache/tvm/pull/8366#discussion_r667585460
##########
File path: src/te/operation/cross_thread_reduction.cc
##########
@@ -177,7 +178,8 @@ Stmt MakeCrossThreadReduction(const ComputeOpNode* self,
const Stage& stage,
std::vector<Var> res_handles(size);
for (size_t idx = 0; idx < size; ++idx) {
DataType dtype = reduces[idx]->dtype;
- res_handles[idx] = Var("reduce_temp" + std::to_string(idx),
PointerType(PrimType(dtype)));
+ res_handles[idx] =
Review comment:
Removal of `AttrStmt` creation with `attr::storage_scope` will come
after this PR, where all `attr::storage_scope` usages will be removed at once.
A lot of places in the code base still assume the existence of `AttrStmt` with
`attr::storage_scope`, so I don't want to remove some AttrStmt while leaving
others in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
