mbaret commented on PR #12550: URL: https://github.com/apache/tvm/pull/12550#issuecomment-1230562123
I'm keen to make progress with this issue and given the AOT codegen is largely untested, I believe this refactor represents a strict improvement over the current situation. The decisions I've made here aren't meant to be final and patches are always welcome to introduce further coverage, including adding specific test cases where community stakeholders care about particular functionality not regressing. To give a more blunt personal view, there's an enormous amount of untested code in TVM with a lot of it poorly specified. If we make the barrier-to-entry for participating in improving that situation '100% coverage', rather than getting full coverage we'll just get no participation. That being said, if we want to update the project's code quality guidelines to be more explicit around testing expectations, I'd be fully supportive of that effort and would happily participate in any discussions arising from an RFC. We can then vote as a community on how we want to go forward rather than having the same debates on a PR-by-PR basis. @lhutton1 could you request further changes/approve, thanks :) @Mousius let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
