mbaret commented on PR #12550: URL: https://github.com/apache/tvm/pull/12550#issuecomment-1231486233
To be clear, this isn't just a case of me refusing to put the test in 'just because it's effort' - I don't agree at a fundamental level with testing an implementation detail that has no _functional_ impact on the behaviour of the component-under-test. Because of this, I don't want to establish precedent for what I believe to be bad practice (such tests have created nightmares for me in the past when refactoring). I accept you have a different view, and I've outlined a path by which the community can come to a consensus on testing best-practices. I don't think the comments on a PR with incredibly limited visibility is the forum for this though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
