mbaret commented on PR #12550: URL: https://github.com/apache/tvm/pull/12550#issuecomment-1241863067
@Mousius As this PR is being blocked and none of my proposals to achieve [consensus](https://tvm.apache.org/docs/contribute/code_review.html#consensus-building) have been acknowleged, I have done the following: - A new function, `CreateStorage`, has been created and exposed in the header to allow `ExprAllocator` to be subjected to testing. - A test has been added to confirm that `StorageInfo` is not allocated for nested functions as requested. Because ExprAllocator is coupled to the implementation of `AOTLowerMain`, I've added a comment to indicate this in the header. Unfortunately, there was no programmatic way to enforce that this function isn't reused outside `AOTLowerMain` without making it untestable. Furthermore, the logic under test is unreachable from `AOTLowerMain` as AOT does not support nested functions and will check fail if they're encountered. Lastly, I would prefer going forward that if committers intend to block PRs indefinitely, in parallel they engage with a consensus building process involving multiple members of the community. Without such engagement, contributors are disempowered to take part in good faith technical discussions which is a [core](https://tvm.apache.org/docs/contribute/code_review.html#building-trust) [tenant](https://tvm.apache.org/docs/contribute/code_review.html#community-participation) of the [review process](https://tvm.apache.org/docs/contribute/community.html#general-development-process). @lhutton1 @ekalda please [approve or request changes explicitly](https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
