the-other-tim-brown commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1726005537
##########
xtable-core/src/main/java/org/apache/xtable/avro/AvroSchemaConverter.java:
##########
@@ -435,6 +440,11 @@ private Schema fromInternalSchema(InternalSchema
internalSchema, String currentP
Schema.createFixed(
internalSchema.getName(), internalSchema.getComment(), null,
fixedSize),
internalSchema);
+ case UUID:
+ Schema uuidSchema =
+ Schema.createFixed(internalSchema.getName(),
internalSchema.getComment(), null, 16);
+ uuidSchema.addProp("logicalType", "uuid");
Review Comment:
This is going to be confusing to someone without knowledge of XTable being
involved since `logicalType` is an existing concept and there is a logical type
with a string base type in avro. We should make it prefixed with xtable or
something like that so someone looking at the schema in Hudi commit is aware
that this is some special context
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaSchemaExtractor.java:
##########
@@ -90,6 +90,7 @@ private DataType convertFieldType(InternalField field) {
return DataTypes.LongType;
case BYTES:
case FIXED:
+ case UUID:
Review Comment:
There is some metadata you an add to a field if I am remember correctly, we
will want to pack some context about the fact that this is a UUID if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
