danielhumanmod commented on code in PR #518:
URL: https://github.com/apache/incubator-xtable/pull/518#discussion_r1726203201
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaSchemaExtractor.java:
##########
@@ -142,12 +144,24 @@ private DataType convertFieldType(InternalField field) {
}
}
+ private Metadata getMetaData(InternalType type) {
+ if (type == InternalType.UUID) {
+ return new MetadataBuilder().putString("xtableLogicalType",
"uuid").build();
+ } else {
+ return Metadata.empty();
+ }
+ }
+
public InternalSchema toInternalSchema(StructType structType) {
- return toInternalSchema(structType, null, false, null);
+ return toInternalSchema(structType, null, false, null, null);
}
private InternalSchema toInternalSchema(
- DataType dataType, String parentPath, boolean nullable, String comment) {
+ DataType dataType,
+ String parentPath,
+ boolean nullable,
+ String comment,
+ Metadata originalMetadata) {
Review Comment:
Add metadata as an input to better determine if a binary value is indeed a
UUID in delta lake conversion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
