vinishjail97 commented on code in PR #533:
URL: https://github.com/apache/incubator-xtable/pull/533#discussion_r1751906534
##########
pom.xml:
##########
@@ -19,19 +19,32 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
<modelVersion>4.0.0</modelVersion>
+ <parent>
Review Comment:
Is this a convention to keep apache artifactId at the top ? Having the root
level project details as the first block is better IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
