rangareddy commented on code in PR #533:
URL: https://github.com/apache/incubator-xtable/pull/533#discussion_r1753902728
##########
pom.xml:
##########
@@ -19,19 +19,32 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
<modelVersion>4.0.0</modelVersion>
+ <parent>
Review Comment:
Old
[pom.xml](https://github.com/apache/incubator-xtable/blob/main/pom.xml#L30) file
```
<groupId>org.apache.xtable</groupId>
<artifactId>xtable</artifactId>
<name>xtable</name>
<inceptionYear>2024</inceptionYear>
<version>0.2.0-SNAPSHOT</version>
<packaging>pom</packaging>
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>33</version>
</parent>
```
New
[pom.xml](https://github.com/apache/incubator-xtable/blob/cd395197efdeacd3d01a87c86f74a49ba9409cc3/pom.xml#L22)
```xml
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>33</version>
</parent>
<groupId>org.apache.xtable</groupId>
<artifactId>xtable</artifactId>
<name>XTable Parent Project</name>
<inceptionYear>2024</inceptionYear>
<version>0.2.0-SNAPSHOT</version>
<packaging>pom</packaging>
<url>https://xtable.apache.org/</url>
```
So reverting the code is not required. Please review the pull request once
again and approve the pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
