rangareddy commented on code in PR #533:
URL: https://github.com/apache/incubator-xtable/pull/533#discussion_r1751986774
##########
pom.xml:
##########
@@ -19,19 +19,32 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
<modelVersion>4.0.0</modelVersion>
+ <parent>
Review Comment:
Yes it is a best practise to keep the parent tag at the beginning of the xml
file. Sample example code from
[Spark](https://github.com/apache/spark/blob/master/streaming/pom.xml#L21)
source code.
```xml
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.spark</groupId>
<artifactId>spark-parent_2.13</artifactId>
<version>4.0.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>spark-streaming_2.13</artifactId>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
