the-other-tim-brown commented on code in PR #533:
URL: https://github.com/apache/incubator-xtable/pull/533#discussion_r1754280862
##########
xtable-api/pom.xml:
##########
@@ -19,15 +19,15 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
<modelVersion>4.0.0</modelVersion>
- <artifactId>xtable-api</artifactId>
- <name>xtable-api</name>
-
<parent>
<groupId>org.apache.xtable</groupId>
<artifactId>xtable</artifactId>
<version>0.2.0-SNAPSHOT</version>
</parent>
+ <artifactId>xtable-api</artifactId>
+ <name>XTable Api Project</name>
Review Comment:
The spark project naming convention seems to be "Spark Project [Module]" -
should we follow that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
