danielhumanmod commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1884743264
##########
xtable-api/src/main/java/org/apache/xtable/spi/sync/TableFormatSync.java:
##########
@@ -149,19 +151,26 @@ private SyncResult getSyncResult(
InternalTable tableState,
SyncFiles fileSyncMethod,
Instant startTime,
- List<Instant> pendingCommits) {
+ List<Instant> pendingCommits,
+ String sourceIdentifier) {
// initialize the sync
conversionTarget.beginSync(tableState);
+ // Persist the latest commit time in table properties for incremental syncs
Review Comment:
Here We need to move the Metadata set operation earlier because it will be
required during the `sync()` operation in Iceberg (Delta and Hudi only need it
in `completeSync()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
