danielhumanmod commented on code in PR #569:
URL: https://github.com/apache/incubator-xtable/pull/569#discussion_r1884744773
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergDataFileUpdatesSync.java:
##########
@@ -60,32 +62,37 @@ public void applySnapshot(
FilesDiff<InternalDataFile, DataFile> diff =
DataFilesDiff.findNewAndRemovedFiles(partitionedDataFiles,
previousFiles);
- applyDiff(transaction, diff.getFilesAdded(), diff.getFilesRemoved(),
schema, partitionSpec);
+ applyDiff(
+ transaction, diff.getFilesAdded(), diff.getFilesRemoved(), schema,
partitionSpec, metadata);
}
public void applyDiff(
Transaction transaction,
DataFilesDiff dataFilesDiff,
Schema schema,
- PartitionSpec partitionSpec) {
+ PartitionSpec partitionSpec,
+ TableSyncMetadata metadata) {
Collection<DataFile> filesRemoved =
dataFilesDiff.getFilesRemoved().stream()
.map(file -> getDataFile(partitionSpec, schema, file))
.collect(Collectors.toList());
- applyDiff(transaction, dataFilesDiff.getFilesAdded(), filesRemoved,
schema, partitionSpec);
+ applyDiff(
+ transaction, dataFilesDiff.getFilesAdded(), filesRemoved, schema,
partitionSpec, metadata);
}
private void applyDiff(
Transaction transaction,
Collection<InternalDataFile> filesAdded,
Collection<DataFile> filesRemoved,
Schema schema,
- PartitionSpec partitionSpec) {
+ PartitionSpec partitionSpec,
+ TableSyncMetadata metadata) {
OverwriteFiles overwriteFiles = transaction.newOverwrite();
filesAdded.forEach(f -> overwriteFiles.addFile(getDataFile(partitionSpec,
schema, f)));
filesRemoved.forEach(overwriteFiles::deleteFile);
+ overwriteFiles.set(TableSyncMetadata.XTABLE_METADATA, metadata.toJson());
Review Comment:
Attach XTable metadata as Iceberg snapshot summary (commit level)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
