kroushan-nit commented on code in PR #632: URL: https://github.com/apache/incubator-xtable/pull/632#discussion_r1937583760
########## xtable-aws/src/main/resources/services/org.apache.xtable.spi.extractor.CatalogConversionSource: ########## @@ -0,0 +1,18 @@ +########################################################################## +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +########################################################################## +org.apache.xtable.glue.GlueCatalogConversionSource Review Comment: ServiceLoader code is already present in a factory class, does it make sense to add more factory classes? Also does it mean we will have to create a **CatalogFactory** interface having `getCatalogType` (for service loader) and `createInstance` method and have Glue and Hive specific factory implementations and use them in META-INF/services instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
