the-other-tim-brown commented on code in PR #632:
URL: https://github.com/apache/incubator-xtable/pull/632#discussion_r1941262466
##########
xtable-core/src/main/java/org/apache/xtable/catalog/Constants.java:
##########
@@ -24,8 +24,26 @@
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public class Constants {
+ /**
+ * This property should be used to specify the data source provider that
Spark uses to read from
+ * or write to the data source. For ex: when working with a Delta table in
AWS Glue, this property
+ * typically points to the Delta Lake format
Review Comment:
Can you include the expected values in the comment? It may be more clear.
With "points to" I was thinking of a pointer to a location on the first pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
