kroushan-nit commented on code in PR #632:
URL: https://github.com/apache/incubator-xtable/pull/632#discussion_r1939131524
##########
xtable-api/src/main/java/org/apache/xtable/spi/extractor/CatalogConversionSource.java:
##########
@@ -32,4 +35,7 @@ public interface CatalogConversionSource {
/** Returns the {@link org.apache.xtable.model.storage.CatalogType} for the
catalog conversion */
String getCatalogType();
+
+ /** Initializes the ConversionSource with provided configuration */
+ void init(ExternalCatalogConfig catalogConfig, Configuration configuration);
Review Comment:
Yes, added during the refactor:
[CatalogConversionFactory](https://github.com/apache/incubator-xtable/pull/632/files#diff-012a61547da73489a3257316b4344c3e3c359e79064a4cca7176b5942bcc6d21)
-
<img width="760" alt="image"
src="https://github.com/user-attachments/assets/0b972391-bcdf-410b-93ac-cadd1c269115";
/>
<img width="770" alt="image"
src="https://github.com/user-attachments/assets/1dc5404f-9350-4512-99e2-8977fe08b594";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
