unical1988 commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2286797711
##########
xtable-core/src/main/java/org/apache/xtable/hudi/PathBasedPartitionValuesExtractor.java:
##########
@@ -81,40 +77,40 @@ public List<PartitionValue> extractPartitionValues(
}
private PartialResult parsePartitionPath(
- InternalPartitionField field, String remainingPath, int
totalNumberOfPartitions) {
+ InternalPartitionField field, String basePath, int
totalNumberOfPartitions) {
switch (field.getTransformType()) {
case YEAR:
+ return parseDate(basePath, field.getSourceField().getPath(), "yyyy");
case MONTH:
case DAY:
case HOUR:
return parseDate(
- remainingPath,
pathToPartitionFieldFormat.get(field.getSourceField().getPath()));
+ basePath, field.getSourceField().getPath(), ""); // TODO adjust
for other cases
Review Comment:
not yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
