unical1988 commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2286796733
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergColumnStatsConverter.java:
##########
@@ -68,12 +72,28 @@ public Metrics toIceberg(Schema schema, long totalRowCount,
List<ColumnStat> fie
nullValueCounts.put(fieldId, columnStats.getNumNulls());
Type fieldType = icebergField.type();
if (columnStats.getRange().getMinValue() != null) {
- lowerBounds.put(
- fieldId, Conversions.toByteBuffer(fieldType,
columnStats.getRange().getMinValue()));
+ if (fieldType.toString() == "string" && format ==
"APACHE_PARQUET") {
Review Comment:
the only way for this converter to read the parquet stat (in case of String
type) is to do this kind of casting. Now I don't know if this can be done
elsewhere e.g. the ParquetStatsExtractor? meaning that I should add the check
for String type and the cast here:
https://github.com/apache/incubator-xtable/blob/fdbd28553e10c0519a2bf95abe5edee099eb8170/xtable-core/src/main/java/org/apache/xtable/parquet/ParquetStatsExtractor.java#L119
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
