unical1988 commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2288338409
##########
xtable-core/src/main/java/org/apache/xtable/parquet/ParquetSchemaExtractor.java:
##########
@@ -270,12 +267,11 @@ public InternalSchema toInternalSchema(Type schema,
String parentPath) {
.fields(valueSchema.getFields())
.build();
} else {
-
subFields = new ArrayList<>(schema.asGroupType().getFields().size());
for (Type parquetField : schema.asGroupType().getFields()) {
String fieldName = parquetField.getName();
Type.ID fieldId = parquetField.getId();
- currentRepetition = parquetField.getRepetition();
+ // currentRepetition = parquetField.getRepetition();
Review Comment:
We don't need the repetition of the last field but that of the group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
