the-other-tim-brown commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2296881609
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergDataFileUpdatesSync.java:
##########
@@ -113,7 +113,10 @@ private DataFile getDataFile(
.withFileSizeInBytes(dataFile.getFileSizeBytes())
.withMetrics(
columnStatsConverter.toIceberg(
- schema, dataFile.getRecordCount(),
dataFile.getColumnStats()))
+ schema,
+ dataFile.getRecordCount(),
+ dataFile.getColumnStats(),
+ dataFile.getFileFormat().toString()))
Review Comment:
This needs to be cleaned up as well. The change in expected args is causing
the mocks to no longer match and that is causing the test failures for Iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
