the-other-tim-brown commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2296839704
##########
xtable-core/src/main/java/org/apache/xtable/hudi/BaseFileUpdatesExtractor.java:
##########
@@ -230,13 +230,14 @@ private WriteStatus toWriteStatus(
writeStat.setNumWrites(file.getRecordCount());
writeStat.setTotalWriteBytes(file.getFileSizeBytes());
writeStat.setFileSizeInBytes(file.getFileSizeBytes());
- writeStat.putRecordsStats(convertColStats(fileName,
file.getColumnStats()));
+ writeStat.putRecordsStats(
+ convertColStats(fileName, file.getColumnStats(),
file.getFileFormat().toString()));
writeStatus.setStat(writeStat);
return writeStatus;
}
private Map<String, HoodieColumnRangeMetadata<Comparable>> convertColStats(
- String fileName, List<ColumnStat> columnStatMap) {
+ String fileName, List<ColumnStat> columnStatMap, String fileFormat) {
Review Comment:
We cannot have this be dependent on fileFormat as mentioned before. The
intermediate object should be standardized so it is not dependent on source
format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
