unical1988 commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2296841187
##########
xtable-core/src/main/java/org/apache/xtable/hudi/BaseFileUpdatesExtractor.java:
##########
@@ -230,13 +230,14 @@ private WriteStatus toWriteStatus(
writeStat.setNumWrites(file.getRecordCount());
writeStat.setTotalWriteBytes(file.getFileSizeBytes());
writeStat.setFileSizeInBytes(file.getFileSizeBytes());
- writeStat.putRecordsStats(convertColStats(fileName,
file.getColumnStats()));
+ writeStat.putRecordsStats(
+ convertColStats(fileName, file.getColumnStats(),
file.getFileFormat().toString()));
writeStatus.setStat(writeStat);
return writeStatus;
}
private Map<String, HoodieColumnRangeMetadata<Comparable>> convertColStats(
- String fileName, List<ColumnStat> columnStatMap) {
+ String fileName, List<ColumnStat> columnStatMap, String fileFormat) {
Review Comment:
Also, pls check with me the current CI error in TestDeltaSync and
TestIcebergSync a tiny error must be in a certain path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
