[
https://issues.apache.org/jira/browse/HADOOP-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069371#comment-15069371
]
Kai Zheng commented on HADOOP-12662:
------------------------------------
In the root {{pom.xml}}, it was found:
{noformat}
pom.xml: <shell-executable>bash</shell-executable>
{noformat}
And look at how it's used:
{noformat}
hadoop-common-project/hadoop-common/pom.xml: <exec
executable="${shell-executable}" failonerror="true"
dir="${project.build.directory}/native">
hadoop-common-project/hadoop-common/pom.xml: <exec
executable="${shell-executable}" failonerror="true"
dir="${project.build.directory}/native">
hadoop-common-project/hadoop-kms/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
hadoop-common-project/hadoop-kms/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
hadoop-dist/pom.xml: <exec executable="${shell-executable}"
dir="${project.build.directory}" failonerror="true">
hadoop-dist/pom.xml: <exec executable="${shell-executable}"
dir="${project.build.directory}" failonerror="true">
hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
failonerror="true">
hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
failonerror="true">
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml:
<exec executable="${shell-executable}" failonerror="true"
dir="${project.build.directory}/native/test">
hadoop-mapreduce-project/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
failonerror="true">
hadoop-mapreduce-project/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
failonerror="true">
hadoop-project-dist/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
failonerror="true">
hadoop-project-dist/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
failonerror="true">
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml:
<exec executable="${shell-executable}" failonerror="true"
dir="${project.build.directory}/native">
hadoop-yarn-project/pom.xml: <exec
executable="${shell-executable}" dir="${project.build.directory}"
failonerror="true">
{noformat}
So it looks like we can safely use {{bash}} to rewrite the script.
> The build should fail if a -Dbundle option fails
> ------------------------------------------------
>
> Key: HADOOP-12662
> URL: https://issues.apache.org/jira/browse/HADOOP-12662
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-12662-v1.patch, HADOOP-12662-v2.patch
>
>
> Per some discussion with [~cmccabe], it would be good to refine and make it
> consistent the behaviors in bundling native libraries when building dist
> package.
> For all native libraries to bundle, if the bundling option like
> {{-Dbundle.snappy}} is specified, then the lib option like {{-Dsnappy.lib}}
> will be checked and ensured to be there, but if not, it will then report
> error and fail the building explicitly.
> {{BUILDING.txt}} would also be updated to explicitly state this behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
