[ https://issues.apache.org/jira/browse/HADOOP-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069925#comment-15069925 ]
Colin Patrick McCabe commented on HADOOP-12662: ----------------------------------------------- I agree that a separate script would be much "cleaner" because you'd be able to factor things out into subroutines, and run the various bash linters on it. I definitely don't have any objection to doing the factoring out in a different JIRA if that makes sense. I think bash is the right choice since we already use it in so many other places, and dealing with shell portability issues is just self-inflicted pain. > The build should fail if a -Dbundle option fails > ------------------------------------------------ > > Key: HADOOP-12662 > URL: https://issues.apache.org/jira/browse/HADOOP-12662 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Kai Zheng > Assignee: Kai Zheng > Attachments: HADOOP-12662-v1.patch, HADOOP-12662-v2.patch > > > Per some discussion with [~cmccabe], it would be good to refine and make it > consistent the behaviors in bundling native libraries when building dist > package. > For all native libraries to bundle, if the bundling option like > {{-Dbundle.snappy}} is specified, then the lib option like {{-Dsnappy.lib}} > will be checked and ensured to be there, but if not, it will then report > error and fail the building explicitly. > {{BUILDING.txt}} would also be updated to explicitly state this behavior. -- This message was sent by Atlassian JIRA (v6.3.4#6332)