[ 
https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899147#action_12899147
 ] 

Luke Lu commented on HADOOP-6884:
---------------------------------

@Steve & Suresh: slf4j support "{}" holders in the format string (which has a 
much faster implementation than jdk MessageFormat), so we don't have to create 
new strings objects with all these + operators and/or implicit toString() 
calls. One can create a few overloads (for number of args under n, and delegate 
to vargs a la slf4j (n=3) for larger n) to avoid vargs (hence the new Object 
array) overhead in common cases. Feature/design/performance aside, the main 
problem of commons logging is that there are no active maintainers working on 
it (last release in 2007), unlike slf4j.

> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HADOOP-6884
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6884
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6884-0.22-1.patch, HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is 
> true, in some cases it's expensive to construct the string that is being 
> printed to log. It's much easier to always use LOG.isDebugEnabled() because 
> it's easier to check (rather than in each case reason whether it's necessary 
> or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to