[ 
https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899441#action_12899441
 ] 

Scott Carey commented on HADOOP-6884:
-------------------------------------

bq. Of course, the other tactic is to say "no layers, go to log4j" and work 
with the log4j team on having log4j push out data to chukwa and scribus, feed 
it back into Hadoop for analysis. Just a thought.

slf4j is log4j's successor, the 'founder' of slf4j is the same person that 
started log4j.  Like commons logging,  log4j is in maintenance mode.  
http://logging.apache.org/log4j/1.2/changes-report.html

One maintenance release in 2.5 years.  Thats good, its stable and simple.  But 
new features or adapters? Unlikely.

> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HADOOP-6884
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6884
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6884-0.22-1.patch, HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is 
> true, in some cases it's expensive to construct the string that is being 
> printed to log. It's much easier to always use LOG.isDebugEnabled() because 
> it's easier to check (rather than in each case reason whether it's necessary 
> or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to