bilaharith commented on a change in pull request #1790: changes for combined append+flush calls for blockblob(traditionan) an… URL: https://github.com/apache/hadoop/pull/1790#discussion_r363223682
########## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsOutputStream.java ########## @@ -0,0 +1,268 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.azurebfs.services; +import java.util.Arrays; +import java.util.HashSet; +import java.util.Random; +import org.junit.Assert; +import org.junit.Test; + +import org.mockito.ArgumentCaptor; +import static org.mockito.Mockito.*; +/** + * Test useragent of abfs client. + * + */ +public final class TestAbfsOutputStream { + + private static int bufferSize = 4096; + private static int writeSize = 1000; + private static String path = "~/testpath"; + + @Test + public void verifyShortWriteRequest() throws Exception { + + AbfsClient client = mock(AbfsClient.class); + AbfsOutputStream out = new AbfsOutputStream(client, path, 0, bufferSize, true, true, false); + final byte[] b = new byte[writeSize]; + new Random().nextBytes(b); + out.write(b); + out.hsync(); + ArgumentCaptor<String> acString = ArgumentCaptor.forClass(String.class); + ArgumentCaptor<Long> acLong = ArgumentCaptor.forClass(Long.class); + ArgumentCaptor<Integer> acInt = ArgumentCaptor.forClass(Integer.class); + ArgumentCaptor<Boolean> acBool = ArgumentCaptor.forClass(Boolean.class); + ArgumentCaptor<byte[]> acByteArray = ArgumentCaptor.forClass(byte[].class); + + final byte[] b1 = new byte[2*writeSize]; + new Random().nextBytes(b1); + out.write(b1); + out.flush(); + out.hflush(); + + out.hsync(); + + verify(client, times(2)).append(acString.capture(), acLong.capture(), acByteArray.capture(), acInt.capture(), acInt.capture(), acBool.capture(), acBool.capture()); + Assert.assertEquals(Arrays.asList(path, path) , acString.getAllValues()); + Assert.assertEquals(Arrays.asList(Long.valueOf(0), Long.valueOf(writeSize)), acLong.getAllValues()); + //flush=true, close=false, flush=true, close=false + Assert.assertEquals(Arrays.asList(true, false, true, false), acBool.getAllValues()); + Assert.assertEquals(Arrays.asList(0,writeSize, 0, 2*writeSize), acInt.getAllValues()); + + verifyNoMoreInteractions(client); + + } + + @Test + public void verifyWriteRequest() throws Exception { + + AbfsClient client = mock(AbfsClient.class); + AbfsOutputStream out = new AbfsOutputStream(client, path, 0, bufferSize, true, true, false); + final byte[] b = new byte[writeSize]; + new Random().nextBytes(b); + + for (int i = 0; i < 5; i++) { + out.write(b); + } + out.close(); + + ArgumentCaptor<String> acString = ArgumentCaptor.forClass(String.class); + ArgumentCaptor<Long> acLong = ArgumentCaptor.forClass(Long.class); + ArgumentCaptor<Integer> acInt = ArgumentCaptor.forClass(Integer.class); + ArgumentCaptor<Boolean> acBool = ArgumentCaptor.forClass(Boolean.class); + ArgumentCaptor<byte[]> acByteArray = ArgumentCaptor.forClass(byte[].class); + + verify(client, times(2)).append(acString.capture(), acLong.capture(), acByteArray.capture(), acInt.capture(), acInt.capture(), acBool.capture(), acBool.capture()); + Assert.assertEquals(Arrays.asList(path, path) , acString.getAllValues()); + Assert.assertEquals(Arrays.asList(Long.valueOf(0), Long.valueOf(bufferSize)), acLong.getAllValues()); + //flush=false,close=false, flush=true,close=true + Assert.assertEquals(Arrays.asList(false, false, true, true), acBool.getAllValues()); + Assert.assertEquals(Arrays.asList(0, bufferSize, 0, 5*writeSize-bufferSize), acInt.getAllValues()); + + verifyNoMoreInteractions(client); + } + + @Test + public void verifyWriteRequestOfBufferSizeAndClose() throws Exception { + + AbfsClient client = mock(AbfsClient.class); + AbfsOutputStream out = new AbfsOutputStream(client, path, 0, bufferSize, true, true, false); + final byte[] b = new byte[bufferSize]; + new Random().nextBytes(b); + + for (int i = 0; i < 2; i++) { + out.write(b); + } + out.close(); + + ArgumentCaptor<String> acString = ArgumentCaptor.forClass(String.class); + ArgumentCaptor<Long> acLong = ArgumentCaptor.forClass(Long.class); + ArgumentCaptor<Integer> acInt = ArgumentCaptor.forClass(Integer.class); + ArgumentCaptor<Boolean> acBool = ArgumentCaptor.forClass(Boolean.class); + ArgumentCaptor<byte[]> acByteArray = ArgumentCaptor.forClass(byte[].class); + + verify(client, times(2)).append(acString.capture(), acLong.capture(), acByteArray.capture(), acInt.capture(), acInt.capture(), acBool.capture(), acBool.capture()); + Assert.assertEquals(Arrays.asList(path, path) , acString.getAllValues()); + Assert.assertEquals(new HashSet<Long>(Arrays.asList(Long.valueOf(0), Long.valueOf(bufferSize))), new HashSet<Long>(acLong.getAllValues())); + //flush=false, close=false, flush=false, close=false + Assert.assertEquals(Arrays.asList(false, false, false, false), acBool.getAllValues()); + Assert.assertEquals(Arrays.asList(0, bufferSize, 0, bufferSize), acInt.getAllValues()); + + ArgumentCaptor<String> acFlushString = ArgumentCaptor.forClass(String.class); + ArgumentCaptor<Long> acFlushLong = ArgumentCaptor.forClass(Long.class); + ArgumentCaptor<Boolean> acFlushBool = ArgumentCaptor.forClass(Boolean.class); + + verify(client, times(1)).flush(acFlushString.capture(), acFlushLong.capture(), acFlushBool.capture(), acFlushBool.capture()); + Assert.assertEquals(Arrays.asList(path) , acFlushString.getAllValues()); + Assert.assertEquals(Arrays.asList(Long.valueOf(2*bufferSize)), acFlushLong.getAllValues()); + Assert.assertEquals(Arrays.asList(false, true), acFlushBool.getAllValues()); + + verifyNoMoreInteractions(client); + } + + @Test + public void verifyWriteRequestOfBufferSize() throws Exception { + + AbfsClient client = mock(AbfsClient.class); + AbfsOutputStream out = new AbfsOutputStream(client, path, 0, bufferSize, true, true, false); + final byte[] b = new byte[bufferSize]; + new Random().nextBytes(b); + + for (int i = 0; i < 2; i++) { + out.write(b); + } + Thread.sleep(1000); + + ArgumentCaptor<String> acString = ArgumentCaptor.forClass(String.class); + ArgumentCaptor<Long> acLong = ArgumentCaptor.forClass(Long.class); + ArgumentCaptor<Integer> acInt = ArgumentCaptor.forClass(Integer.class); + ArgumentCaptor<Boolean> acBool = ArgumentCaptor.forClass(Boolean.class); + ArgumentCaptor<byte[]> acByteArray = ArgumentCaptor.forClass(byte[].class); + + verify(client, times(2)).append(acString.capture(), acLong.capture(), acByteArray.capture(), acInt.capture(), acInt.capture(), acBool.capture(), acBool.capture()); + Assert.assertEquals(Arrays.asList(path, path) , acString.getAllValues()); + Assert.assertEquals(new HashSet<Long>(Arrays.asList(Long.valueOf(0), Long.valueOf(bufferSize))), new HashSet<Long>(acLong.getAllValues())); + //flush=false, close=false, flush=false, close=false + Assert.assertEquals(Arrays.asList(false, false, false, false), acBool.getAllValues()); + Assert.assertEquals(Arrays.asList(0, bufferSize, 0, bufferSize), acInt.getAllValues()); + + verifyNoMoreInteractions(client); + } + + @Test + public void verifyWriteRequestOfBufferSizeWithAppendBlob() throws Exception { + + AbfsClient client = mock(AbfsClient.class); + AbfsOutputStream out = new AbfsOutputStream(client, path, 0, bufferSize, true, true, true); + final byte[] b = new byte[bufferSize]; + new Random().nextBytes(b); + + for (int i = 0; i < 2; i++) { + out.write(b); + } + Thread.sleep(1000); + + ArgumentCaptor<String> acString = ArgumentCaptor.forClass(String.class); + ArgumentCaptor<Long> acLong = ArgumentCaptor.forClass(Long.class); + ArgumentCaptor<Integer> acInt = ArgumentCaptor.forClass(Integer.class); + ArgumentCaptor<Boolean> acBool = ArgumentCaptor.forClass(Boolean.class); + ArgumentCaptor<byte[]> acByteArray = ArgumentCaptor.forClass(byte[].class); Review comment: can the lines 171-185 be made a separate method and reuse in the test methods ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
